[DataGridPro] Fix Tree Data and Row Grouping rows accessibility #13623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
bug 🐛
|
Deploy preview: https://deploy-preview-13623--material-ui-x.netlify.app/ Updated pages: |
romgrk
reviewed
Jun 25, 2024
romgrk
changed the title
arminmeh
force-pushed
the
expandable-rows-not-accessible
branch
from
b616ce8
to
b75e0fe
Compare
cherniavskii
reviewed
Jul 1, 2024
packages/x-data-grid-pro/src/hooks/features/treeData/useGridTreeDataPreProcessors.tsx
Outdated
Show resolved
Hide resolved
MBilalShafi
reviewed
Jul 2, 2024
packages/x-data-grid-pro/src/hooks/features/treeData/useGridTreeDataPreProcessors.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jul 3, 2024
packages/x-data-grid-premium/src/DataGridPremium/DataGridPremium.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jul 3, 2024
|
As the original poster of #10032, I just want to thank you for taking this on! I had a look at the preview the bot posted and it looks good to me! It has all the attributes I'd expect and the numbers are right. Thanks again, Armand |
romgrk
reviewed
Jul 4, 2024
packages/x-data-grid/src/hooks/features/rows/useGridRowAriaAttributes.tsx
Show resolved
Hide resolved
romgrk
reviewed
Jul 4, 2024
packages/x-data-grid/src/hooks/features/rows/useGridRowAriaAttributes.tsx
Outdated
Show resolved
Hide resolved
cherniavskii
changed the title
arminmeh
force-pushed
the
expandable-rows-not-accessible
branch
from
0be3e83
to
5886b5e
Compare
arminmeh
commented
Jul 11, 2024
...ta-grid-pro/src/hooks/features/serverSideTreeData/useGridDataSourceTreeDataPreProcessors.tsx
Show resolved
Hide resolved
arminmeh
force-pushed
the
expandable-rows-not-accessible
branch
from
1246f5b
to
f3346cf
Compare
cherniavskii
approved these changes
Jul 12, 2024
packages/x-data-grid-pro/src/hooks/features/rows/useGridRowAriaAttributes.tsx
Outdated
Show resolved
Hide resolved
arminmeh
force-pushed
the
expandable-rows-not-accessible
branch
from
898ce3c
to
83c7554
Compare
romgrk
reviewed
Jul 17, 2024
packages/x-data-grid-pro/src/hooks/features/serverSideTreeData/utils.ts
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jul 17, 2024
packages/x-data-grid/src/hooks/features/rows/useGridRowAriaAttributes.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jul 17, 2024
packages/x-data-grid-pro/src/hooks/features/rows/useGridRowAriaAttributes.tsx
Outdated
Show resolved
Hide resolved
cherniavskii
changed the title
cherniavskii
added
the
feature: Row grouping
5 tasks
1 task
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10032
Used this as a reference
https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/examples/treegrid-1/
Also fixes the issue with the value of
aria-rowcountas it was not updated after filteringw3c/aria-practices#465