-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid][docs] Add overlay documentation #13624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
changed the title
Add overlay documentation
[DataGrid] Add overlay documentation
Jun 25, 2024
KenanYusuf
added
docs
Improvements or additions to the documentation
component: data grid
This is the name of the generic UI component, not the React module!
labels
Jun 25, 2024
KenanYusuf
changed the title
[DataGrid] Add overlay documentation
[DataGrid][docs] Add overlay documentation
Jun 25, 2024
cherniavskii
approved these changes
Jun 25, 2024
Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Kenan Yusuf <[email protected]>
KenanYusuf
force-pushed
the
overlays-docs
branch
2 times, most recently
from
June 26, 2024 09:13
a418264
to
a14d0cd
Compare
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Kenan Yusuf <[email protected]> Co-authored-by: Andrew Cherniavskii <[email protected]>
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Kenan Yusuf <[email protected]> Co-authored-by: Andrew Cherniavskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
customization: css
Design CSS customizability
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new section to the Data Grid documentation to cover the various overlays, including: No rows overlay, No results overlay and Loading overlay.
https://deploy-preview-13624--material-ui-x.netlify.app/x/react-data-grid/overlays/
Changes include:
To add some more context as to why this change is being made, we are adding variants to the Loading overlay (#13293) and there didn't feel like another suitable place to document these options.