[codemod] Fix experimentalFeatures codemod for typescript parser
#14150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
|
Deploy preview: https://deploy-preview-14150--material-ui-x.netlify.app/ |
arminmeh
reviewed
Sep 2, 2024
...a-grid/remove-stabilized-experimentalFeatures/remove-stabilized-experimentalFeatures.test.ts
Outdated
Show resolved
Hide resolved
arminmeh
approved these changes
Sep 3, 2024
This was referenced Sep 27, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12874
Weirdly so, the tsx parser vs js parser sometimes behaves differently. It was the case with the
removeObjectPropertyutility being used in theexperimentalFeaturescodemod.This can be visualized here. Try commenting the line 3 of the codemod script
export const parser = "tsx";to have the codemod remove theexperimentalFeaturesprop properly.The typescript parser parses the node as
ObjectPropertywhile the js parser parses asProperty.I was not aware of this and I think we should be mindful of testing with both compilers before shipping new codemods.