Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Fix the parameters passed for the canMoveItemToNewPosition prop #14176

Merged
merged 3 commits into from
Aug 12, 2024
Merged

[TreeView] Fix the parameters passed for the canMoveItemToNewPosition prop #14176

merged 3 commits into from
Aug 12, 2024

Conversation

flaviendelangle
Copy link
Member

Fixes #14175

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Aug 12, 2024
@flaviendelangle flaviendelangle self-assigned this Aug 12, 2024
@mui-bot
Copy link

mui-bot commented Aug 12, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14176--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2d1ac81

michelengelen
michelengelen approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a simple non-blocking question ... LGTM! :shipit:

...tree-view-pro/src/internals/plugins/useTreeViewItemsReordering/useTreeViewItemsReordering.ts Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle merged commit 01fa734 into mui:master Aug 12, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the canMoveItemToNewPosition-bug branch August 12, 2024 15:27
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Closed
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Closed
Closed
This was referenced Sep 20, 2024
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@JCQuintas JCQuintas JCQuintas approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TreeView] canMoveItemToNewPosition params not providing correct itemId to function
4 participants
@flaviendelangle @mui-bot @JCQuintas @michelengelen