Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Introduce selectors with arguments #14236

Merged
merged 6 commits into from
Aug 22, 2024
Merged

[DataGrid] Introduce selectors with arguments #14236

merged 6 commits into from
Aug 22, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Aug 16, 2024 •
edited
Loading

Extracted from #13757
Related discussion: https://github.com/mui/mui-x/pull/13757/files#r1686750062

Changelog

  • Add new v8 variants of useGridSelector, createSelector, and createSelectorMemoized named as useGridSelectorV8, createSelectorV8, and createSelectorMemoizedV8. Selectors created with createSelectorV8 or createSelectorMemoizedV8 must be used with useGridSelectorV8 for them to work properly. These new variants will replace the existing props in v8.

Todos

  • Add the breaking changes to umbrella issue

@MBilalShafi MBilalShafi added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience labels Aug 16, 2024
@mui-bot
Copy link

mui-bot commented Aug 16, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14236--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b9f5292

@MBilalShafi MBilalShafi mentioned this pull request Aug 16, 2024
Merged
11 tasks
@MBilalShafi MBilalShafi marked this pull request as ready for review August 16, 2024 14:41
@MBilalShafi MBilalShafi requested a review from a team August 16, 2024 14:41
romgrk
romgrk approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as useGridSelectorV8 isn't public we can still refactor it if we find an issue with it later, so I'm good with merging this PR as it is.

@MBilalShafi MBilalShafi changed the title [DataGrid] Selectors with arguments [DataGrid] Introduce selectors with arguments Aug 22, 2024
@MBilalShafi MBilalShafi enabled auto-merge (squash) August 22, 2024 10:54
@MBilalShafi MBilalShafi mentioned this pull request Aug 22, 2024
Open
3 tasks
@MBilalShafi MBilalShafi merged commit c94b26d into mui:master Aug 22, 2024
16 checks passed
@MBilalShafi MBilalShafi deleted the selectors-with-arguments branch August 22, 2024 11:26
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Closed
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 18, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 19, 2024
Closed
@mbreadmachine mbreadmachine mentioned this pull request Sep 20, 2024
Closed
This was referenced Sep 20, 2024
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Closed
This was referenced Sep 27, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes dx Related to developers' experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MBilalShafi @mui-bot @romgrk @arminmeh