Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix dragging styles removal in Column ordering #14680

Merged
merged 2 commits into from
Sep 28, 2024
Merged

[DataGridPro] Fix dragging styles removal in Column ordering #14680

merged 2 commits into from
Sep 28, 2024

Conversation

k-rajat19
Copy link
Contributor

fixes #14678

@k-rajat19 k-rajat19 changed the title Column reorder [DataGridPro] Fix dragging styles removal in Column ordering Sep 20, 2024
@mui-bot
Copy link

mui-bot commented Sep 20, 2024

Deploy preview: https://deploy-preview-14680--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3a7ece8

@michelengelen michelengelen added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature labels Sep 20, 2024
michelengelen
michelengelen reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i'd like a review from @KenanYusuf or @MBilalShafi since I am not familiar with the implications here

@k-rajat19
Copy link
Contributor Author

Sure,
also, this issue is not in v6 because in v6 it is not possible to start dragging from the very edge of the menu icon button
this becomes possible after changes in the design of column header in this PR #14293 I think.

MBilalShafi
MBilalShafi approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBilalShafi MBilalShafi merged commit 1cfe453 into mui:master Sep 28, 2024
23 of 24 checks passed
@k-rajat19 k-rajat19 deleted the column-reorder branch September 28, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen left review comments

@KenanYusuf KenanYusuf KenanYusuf approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Column header get stuck with dragging styles
5 participants
@k-rajat19 @mui-bot @KenanYusuf @MBilalShafi @michelengelen