Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add custom columns panel demo #14825

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 4, 2024

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability feature: Column groups Related to the data grid Column groups feature labels Oct 4, 2024
@mui-bot
Copy link

mui-bot commented Oct 4, 2024

@cherniavskii cherniavskii marked this pull request as ready for review October 7, 2024 21:05
Copy link
Contributor

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one minor styling suggestion to increase the indentation of nested items.

label={group.headerName ?? group.groupId}
onChange={(_, newValue) => toggleColumnGroup(newValue)}
/>
<Box sx={{ pl: 1 }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Box sx={{ pl: 1 }}>
<Box sx={{ pl: 3.5 }}>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability docs Improvements or additions to the documentation feature: Column groups Related to the data grid Column groups feature feature: Column visibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants