[core] Support @mui/utils v6
#14867
Merged
[core] Support @mui/utils v6
#14867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
requested review from
cherniavskii and
LukasTy
and removed request for
cherniavskii
|
Deploy preview: https://deploy-preview-14867--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Oct 8, 2024
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.25.7", | |||
| "@mui/utils": "^5.16.6" | |||
| "@mui/utils": "^5.16.6 || ^6.0.0" | |||
There was a problem hiding this comment.
I had to expand @mui/utils version flexibility on some additional libraries to avoid duplicate downloads (i.e. @mui/x-internals package is used by many other packages).
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14866
Root cause
From https://codesandbox.io/p/sandbox/elegant-tree-xspyf2?file=%2Finitialize.ts%3A5%2C1,
It's the inconsistency of
@mui/utilsversion.@mui/material=>@mui/utilsv6@mui-x/data-grid=>@mui/utilsv5That's why configuring the classNameGenerator from
@mui/material(using@mui/utilsv6) does not affect DataGrid which is using@mui/utilsv5.