[codemod] Add a new utility to rename imports #14919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
force-pushed
the
codemod-rename-imports
branch
from
5c36976
to
3c1bc74
Compare
|
Deploy preview: https://deploy-preview-14919--material-ui-x.netlify.app/ |
flaviendelangle
requested review from
michelengelen,
alexfauquette and
noraleonte
flaviendelangle
changed the title
noraleonte
approved these changes
Oct 11, 2024
Co-authored-by: Nora <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Nora <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
LukasTy
approved these changes
Oct 11, 2024
No, the test were not running and the test output were not correct (but never used so everything passed) |
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #14913
We start to have a lot of codemods that just move imports around, a clean abstraction starts to be worth it
I did not update the grid codemod because their import management differs (there is no nested imports).
Several tree view codemod were not tested because I forgot to add
.testin the test file, this is why the testing files might change slightly.