[TreeView] Fix alpha usage with CSS variables
#14969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kilian <[email protected]>
LukasTy
reviewed
Oct 15, 2024
| @@ -24,26 +24,26 @@ const TreeItem2DragAndDropOverlayRoot = styled('div', { | |||
| style: { | |||
| marginLeft: 'calc(var(--TreeView-indentMultiplier) * var(--TreeView-itemDepth))', | |||
| borderRadius: theme.shape.borderRadius, | |||
| backgroundColor: alpha((theme.vars || theme).palette.primary.dark, 0.15), | |||
| backgroundColor: alpha(theme.palette.primary.dark, 0.15), | |||
There was a problem hiding this comment.
The correct solution can be found here:
mui-x/packages/x-tree-view/src/TreeItem2/TreeItem2.tsx
Lines 84 to 86 in 3f12d3d
Would you be able to apply the necessary changes? 🤔
LukasTy
added
bug 🐛
|
June noticed that in #14772, but nice to have it fixed independently 👌 |
LukasTy
changed the title
alpha usage with CSS variables
LukasTy
reviewed
Oct 16, 2024
| ...theme.applyStyles('dark', { | ||
| borderBottomColor: alpha((theme.vars || theme).palette.grey[900], 0.6), | ||
| borderBottomColor: theme.vars ? `rgba(${theme.vars.palette.grey[900]} / ${0.6})` : alpha(theme.palette.grey[900], 0.6), |
There was a problem hiding this comment.
@flaviendelangle @noraleonte could you double check if this is not an error? 🤔
It seems that this should maybe use grey[100] as in all other cases for the dark theme. 🤔
Now it does nothing... 🤷
LukasTy
reviewed
Oct 16, 2024
packages/x-tree-view/src/TreeItem2DragAndDropOverlay/TreeItem2DragAndDropOverlay.tsx
Outdated
Show resolved
Hide resolved
…DragAndDropOverlay.tsx Signed-off-by: Lukas Tyla <[email protected]>
|
Deploy preview: https://deploy-preview-14969--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Oct 16, 2024
packages/x-tree-view/src/TreeItem2DragAndDropOverlay/TreeItem2DragAndDropOverlay.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/TreeItem2DragAndDropOverlay/TreeItem2DragAndDropOverlay.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/TreeItem2DragAndDropOverlay/TreeItem2DragAndDropOverlay.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Tyla <[email protected]>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14349.