-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Improve type coverage of colDef #2188
Conversation
@m4theushw I removed the |
Follow up on #2189 (comment) |
docs/src/pages/components/data-grid/columns/RenderExpandCellGrid.js
Outdated
Show resolved
Hide resolved
How did we get away from the circular dependency in the types? |
@oliviertassinari the type-only import ( microsoft/TypeScript#35200 |
@flaviendelangle Ok, I didn't know that TypeScript support circular type declaration. It sounds interesting to give it a try and see if it fly at scale or not. At least, we would have found and fixed other issues in the codebase. |
I tried to build https://github.com/mui-org/material-ui-x/pull/2213/files#diff-b98630eb301ddfb1b291caade7edafda784e434b852f21efc232324774d4857eR37 Alternatively, the api: import('../api/gridApi').GridApi |
Fixes #2187
Other public methods that are not typed
onStateChange
is not typed (but may be removed [docs] Add missing API docs #2167)