-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Allow nested LocalizationProvider
#6011
Merged
flaviendelangle
merged 11 commits into
mui:next
from
flaviendelangle:locale-text-override
Sep 9, 2022
Merged
[pickers] Allow nested LocalizationProvider
#6011
flaviendelangle
merged 11 commits into
mui:next
from
flaviendelangle:locale-text-override
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
This is the name of the generic UI component, not the React module!
label
Sep 2, 2022
flaviendelangle
changed the title
[pickers] Allow nested LocalizationProvider
[pickers] Allow nested Sep 2, 2022
LocalizationProvider
These are the results for the performance tests:
|
alexfauquette
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
I'm removing the |
oliviertassinari
pushed a commit
to oliviertassinari/mui-x
that referenced
this pull request
Sep 12, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
v6.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5844
This PR focuses on supporting nested
LocalizationProvider
so that we can add a small wrapper on all pickers component callingLocalizationProvider
withprops.localeText
.This will also allow users to create one top level
LocalizationProvider
with the adapter (or even in the theme) and createLocalizationProvider
deeper in the tree if they want to adapter theadapterLocale
or thelocaleText
.I added le
localeText
onDesktopDatePickers
for demonstration purpose.LocalizationProvider['locale']