Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update to typescript 4.8.3 (target master) #6136

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

flaviendelangle
Copy link
Member

Equivalent of #5935 but for v5

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes typescript labels Sep 13, 2022
@flaviendelangle flaviendelangle self-assigned this Sep 13, 2022
@mui-bot
Copy link

mui-bot commented Sep 13, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 808.2 1,099.9 808.2 917.64 118.863
Sort 100k rows ms 851.1 1,316.1 1,285.3 1,162.36 165.56
Select 100k rows ms 320.8 557.3 334 383.16 89.715
Deselect 100k rows ms 168.5 343.9 264.1 255.22 57.506

Generated by 🚫 dangerJS against ceafb96

@flaviendelangle flaviendelangle mentioned this pull request Sep 13, 2022
1 task
@flaviendelangle flaviendelangle merged commit 71a548f into mui:master Sep 13, 2022
@arunmmanoharan
Copy link

@flaviendelangle Is this released? I see that the package has a new change today. But I do still get the same build error.

@flaviendelangle
Copy link
Member Author

Which version of the package are your using ?
If you could create a small reproduction case, I don't have the error anymore but maybe I'm missing some specificity of your project.

@sheuertz
Copy link

Hi,
I'm still getting this issue as well:

node_modules/@mui/x-date-pickers/internals/models/muiPickersAdapter.d.ts:2:55 - error TS2344: Type 'TDate' does not satisfy the constraint 'ExtendableDateType'.

2 export declare type MuiPickersAdapter<TDate> = IUtils<TDate>;
                                                        ~~~~~

  node_modules/@mui/x-date-pickers/internals/models/muiPickersAdapter.d.ts:2:39
    2 export declare type MuiPickersAdapter<TDate> = IUtils<TDate>;
                                            ~~~~~
    This type parameter might need an `extends ExtendableDateType` constraint.


Found 1 error in node_modules/@mui/x-date-pickers/internals/models/muiPickersAdapter.d.ts:2

These are my @mui dependencies, updated to latest today:

"@mui/icons-material": "^5.10.6",
"@mui/material": "^5.10.6",
"@mui/system": "^5.10.6",
"@mui/x-data-grid-pro": "^5.17.3",
"@mui/x-date-pickers-pro": "^5.0.2",

On typescript 4.8.3.

Thanks

@Methuselah96
Copy link
Contributor

Methuselah96 commented Sep 19, 2022

@flaviendelangle Yes, this is still an issue. It looks like the @ts-ignore applied here does not make it into the built declaration file.

@Methuselah96
Copy link
Contributor

Methuselah96 commented Sep 19, 2022

@flaviendelangle Here is a repo with the error: https://github.com/Methuselah96/mui-x-type-issue. The key is setting skipLibCheck to false. Let me know if there's anything I can do to help move this along. I looked into extending from ExtendableDateType everywhere the TDate generic is used, but the changes seemed quite extensive, so I figured I would check here first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants