Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update monorepo #6180

Merged
merged 2 commits into from
Sep 16, 2022
Merged

[core] Update monorepo #6180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f788b3c
[core] Update monorepo
flaviendelangle Sep 16, 2022
ff0ad5b
Generate proptypes
flaviendelangle Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"@mnajdova/enzyme-adapter-react-18": "^0.2.0",
"@mui/icons-material": "^5.10.3",
"@mui/material": "^5.10.4",
"@mui/monorepo": "https://github.com/m4theushw/material-ui.git#master",
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master",
Copy link
Member

@oliviertassinari oliviertassinari Sep 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be?

Suggested change
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master",
"@mui/monorepo": "https://github.com/mui/material-ui.git#master",

I plan to merge mui/material-ui#34259, I will need it to be on the main release line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that, unless it has been fixed and I don't know, the codesandbox cache of the mui repo is still broken.
It's the problem when migrating Argos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created codesandbox/codesandbox-ci-ui#49 but I don't hope they will implement this. There're issues from last year without any comment in this repo.

Copy link
Member

@oliviertassinari oliviertassinari Sep 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I think that I could solve the issue. See the build history at https://ci.codesandbox.io/status/mui/mui-x/pr/5938.

  • 294382 failed, I started to look at a fix
  • 294385 failed again with the first attempt I did
  • 294386 passed with the second attempt I did 0d204c9
  • 294388 still passed with a git revert of 0d204c9

So I went ahead I opened #6188, #6189 for our two base branches.

"@mui/utils": "^5.10.3",
"@octokit/plugin-retry": "^3.0.9",
"@octokit/rest": "^18.12.0",
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2518,9 +2518,9 @@
react-is "^18.2.0"
react-transition-group "^4.4.5"

"@mui/monorepo@https://github.com/m4theushw/material-ui.git#master":
version "5.10.4"
resolved "https://github.com/m4theushw/material-ui.git#0189797d23c6469438c7dc68db214f490697ebce"
"@mui/monorepo@https://github.com/flaviendelangle/material-ui.git#master":
version "5.10.5"
resolved "https://github.com/flaviendelangle/material-ui.git#002ab79b77d4d88add840e21c5101137a4a7de5a"

"@mui/private-theming@^5.10.3":
version "5.10.3"
Expand Down