Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Reduce the amount of updated screenshots reported by Argos #6310

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Sep 27, 2022

Backport of #6099 and #6032
The goal is to reduce the amount of changes detected by Argos when submitting PRs to master.

Before: https://app.argos-ci.com/mui/mui-x/builds/4255
Screenshot 2022-09-27 at 17 37 04

After: https://app.argos-ci.com/mui/mui-x/builds/4285
Screenshot 2022-09-27 at 18 42 15

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Sep 27, 2022
@mui-bot
Copy link

mui-bot commented Sep 27, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 530.7 994.8 677.6 734.5 185.012
Sort 100k rows ms 696.9 1,109.8 696.9 903.3 167.773
Select 100k rows ms 182.4 293.6 277.5 257.74 39.672
Deselect 100k rows ms 177.8 328.1 197.7 223.46 53.725

Generated by 🚫 dangerJS against 3878c7b

@cherniavskii cherniavskii changed the title [core] Remove storybook master [core] Remove storybook Sep 27, 2022
Copy link
Member

@DanailH DanailH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cherry-pick from of the commits against next, right? The number of files changed seems to be the same.

@cherniavskii
Copy link
Member Author

@DanailH

This is a cherry-pick from of the commits against next, right?

Yes, I cherry-picked merge commits from the next branch

The number of files changed seems to be the same.

Do you mean changes in Argos? The amount of updated screenshots is down from 22 to 3

@cherniavskii cherniavskii marked this pull request as ready for review September 28, 2022 09:41
@DanailH
Copy link
Member

DanailH commented Sep 28, 2022

Do you mean changes in Argos? The amount of updated screenshots is down from 22 to 3

No I meant the git diff.

@cherniavskii
Copy link
Member Author

cherniavskii commented Sep 28, 2022

@DanailH There are 3 commits:

So the amount of files changed is different that in #6099, but it's expected

@cherniavskii cherniavskii changed the title [core] Remove storybook [core] Reduce the amount of updated screenshots reported Argos Sep 28, 2022
@flaviendelangle
Copy link
Member

few manually picked changes from #5999 to reduce the amount of updated screenshots

I can confirm that the changes picked from this PR are compatible with v5
It's just demo on which we forgot to spread the initial state so it was still using the old hide api.

@cherniavskii cherniavskii changed the title [core] Reduce the amount of updated screenshots reported Argos [core] Reduce the amount of updated screenshots reported by Argos Sep 28, 2022
@cherniavskii cherniavskii merged commit 0056a05 into mui:master Sep 28, 2022
@cherniavskii cherniavskii deleted the remove-storybook-master branch September 28, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants