Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Fix aria-labelledby assignment to dialog #7608

Merged
merged 24 commits into from
Jan 26, 2023
Merged

[pickers] Fix aria-labelledby assignment to dialog #7608

merged 24 commits into from
Jan 26, 2023

Commits on Jan 18, 2023

  1. Fix aria-labelledby on mobile picker dialog paper

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c27a3ed View commit details
    Browse the repository at this point in the history

  2. Handle case when toolbar is hidden and label is empty

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c4a695a View commit details
    Browse the repository at this point in the history

  3. Handle mobile date range picker

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    27fd8b0 View commit details
    Browse the repository at this point in the history

  4. fix lint issues

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b84a5fc View commit details
    Browse the repository at this point in the history

  5. Handle desktop pickers

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d166f5e View commit details
    Browse the repository at this point in the history

  6. proptypes

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    86d1d2f View commit details
    Browse the repository at this point in the history

  7. Actually handle titleId privately

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b5eb9b8 View commit details
    Browse the repository at this point in the history

  8. fix

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    8771a10 View commit details
    Browse the repository at this point in the history

  9. Fix to not post warning for DesktopTimePicker without views

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    074460f View commit details
    Browse the repository at this point in the history

  10. Update tests to include label and avoid warning being thrown

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2606211 View commit details
    Browse the repository at this point in the history

  11. Add test cases asserting pickers aria-labelledby relationship

    @LukasTy
    LukasTy committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    6a1e69a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Code review: Flavien

    @LukasTy
    LukasTy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    75ac81e View commit details
    Browse the repository at this point in the history

  2. Code review: Flavien 2

    @LukasTy
    LukasTy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    fc0348b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/next' into fix-pickers-aria-labe… 

    …lledby
    @LukasTy
    LukasTy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    fabf4e0 View commit details
    Browse the repository at this point in the history

  4. Remove redundant omit

    @LukasTy
    LukasTy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    026af96 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Merge remote-tracking branch 'origin/next' into fix-pickers-aria-labe… 

    …lledby
    @LukasTy
    LukasTy committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    10484bb View commit details
    Browse the repository at this point in the history

  2. Update refactored test file

    @LukasTy
    LukasTy committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3e20a2d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge remote-tracking branch 'origin/next' into fix-pickers-aria-labe… 

    …lledby
    @LukasTy
    LukasTy committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7a47004 View commit details
    Browse the repository at this point in the history

  2. Fix types

    @LukasTy
    LukasTy committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    fcedecf View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Code review: Alex 

    - Simplify code
    @LukasTy
    LukasTy committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c8c4a75 View commit details
    Browse the repository at this point in the history

  2. Remove warnings

    @LukasTy
    LukasTy committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b8f10dd View commit details
    Browse the repository at this point in the history

  3. Revert no longer relevant test file changes

    @LukasTy
    LukasTy committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b34a2aa View commit details
    Browse the repository at this point in the history

  4. Add documentation section regarding aria-labelledby behavior

    @LukasTy
    LukasTy committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9f6532e View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Lukas <[email protected]>
    @LukasTy @alexfauquette
    LukasTy and alexfauquette authored Jan 26, 2023
    Configuration menu
    Copy the full SHA
    a7de910 View commit details
    Browse the repository at this point in the history