[test] Fix flaky tests #8097
Merged
[test] Fix flaky tests #8097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
test
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8097--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
1 task
LukasTy
approved these changes
Mar 2, 2023
packages/grid/x-data-grid-pro/src/tests/detailPanel.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid-pro/src/tests/detailPanel.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
|
@LukasTy let me know if you notice any flaky tests after merging this PR. |
|
I've seen some false negatives in #8108, I'll look into it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7986 (comment)
If it works well, I'll submit a PR that would remove
fakeclock in other tests as well.