Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Forward digital clock classes #9555

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[pickers] Forward digital clock classes #9555

merged 1 commit into from
Jul 4, 2023

Conversation

YoonjiJang
Copy link
Contributor

@YoonjiJang YoonjiJang commented Jul 3, 2023 •
edited
Loading

forward classes prop in DigitalClock component

@mui-bot
Copy link

mui-bot commented Jul 3, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9555--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 315.9 501.8 495 429.3 85.578
Sort 100k rows ms 617.2 959.2 865.3 842.86 118.056
Select 100k rows ms 225.1 333.9 268.6 281.08 41.869
Deselect 100k rows ms 196.4 270.6 225.5 234.04 31.188

Generated by 🚫 dangerJS against 9ec9aab

LukasTy
LukasTy approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a nice improvement! 💯

@LukasTy LukasTy added component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. labels Jul 4, 2023
@LukasTy LukasTy changed the title [pickers] forward digital clock classes [pickers] Forward digital clock classes Jul 4, 2023
@LukasTy LukasTy merged commit 0908778 into mui:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoonjiJang @mui-bot @LukasTy