Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I10n] Improve Norwegian (nb-NO) locale #9608

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

JosteinBrevik
Copy link
Contributor

@JosteinBrevik JosteinBrevik commented Jul 7, 2023

@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Jul 7, 2023
@mui-bot
Copy link

mui-bot commented Jul 7, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9608--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 311.1 498.7 382.8 385.72 70.614
Sort 100k rows ms 515.1 807.4 796.7 709.22 118.995
Select 100k rows ms 189.4 302.3 206 220.04 42.068
Deselect 100k rows ms 124.9 288.7 216.4 224.9 60.012

Generated by 🚫 dangerJS against 5b80777

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏
Please follow the tips in #9608 (comment) to make the CI green. 👌

@JosteinBrevik
Copy link
Contributor Author

There it is! Thanks for the help and sorry for the spam :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants