Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node and jsdom tests interferring with each other #939

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 8, 2022

Correct the way jsdom env was set up and how TextEncoder was polyfilled. This allows us to use the node environment without having the setupFilesAfterEnv running.

closes #930

@render
Copy link

render bot commented Sep 8, 2022

@oliviertassinari oliviertassinari requested a deployment to fix-tests - toolpad-db PR #939 September 8, 2022 12:22 — with Render Abandoned
@Janpot Janpot marked this pull request as ready for review September 8, 2022 12:42
@Janpot Janpot merged commit d9afba6 into master Sep 8, 2022
@Janpot Janpot deleted the fix-tests branch September 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants