This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
Fixes #98: Do not send empty scopes to an auth server #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoiko
suggested changes
Jul 29, 2020
There was a problem hiding this comment.
I think we should let the user have control over the value of scope that is sent to the server. If scopes is set to "" or [] then we should send an empty string (that's what sanitizeScope() currently does). If scopes is undefined (not set), then we shouldn't send it at all (that part is what needs to be fixed).
Reworked. |
jstoiko
approved these changes
Aug 2, 2020
Merged
clancy-au
pushed a commit
to digiwise/js-client-oauth2
that referenced
this pull request
Apr 21, 2021
…ulesoft-labs#154) If `scopes` is set to `""` or `[]` then we should send an empty string. If `scopes` is undefined (not set), then we don't send it at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98