Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W-14250766-added 4.5 example. Removed unsupported sample #2566

Merged
merged 4 commits into from
Oct 6, 2023
Merged

W-14250766-added 4.5 example. Removed unsupported sample #2566

merged 4 commits into from
Oct 6, 2023

Conversation

nparente-mulesoft
Copy link

@nparente-mulesoft nparente-mulesoft commented Oct 5, 2023 •
edited by dmerlob
Loading

Writer's Quality Checklist

Before merging your PR, did you:

  • Run spell checker
  • Run link checker to check for broken xrefs
  • Check for orphan files
  • Perform a local build and do a final visual check of your content, including checking for:
    • Broken images
    • Dead links
    • Correct rendering of partials if they are used in your content
    • Formatting issues, such as:
      • Misnumbered ordered lists (steps) or incorrectly nested unordered lists
      • Messed up tables
      • Proper indentation
      • Correct header levels
  • Receive final review and signoff from:
    • Technical SME
    • Product Manager
    • Editor or peer reviewer
    • Reporter, if this content is in response to a reported issue (internal or external feedback)
  • If applicable, verify that the software actually got released

egrave
egrave previously approved these changes Oct 6, 2023
View reviewed changes
@dmerlob dmerlob self-assigned this Oct 6, 2023
dmerlob
dmerlob previously approved these changes Oct 6, 2023
View reviewed changes
modules/ROOT/pages/deploy-to-cloudhub.adoc Outdated Show resolved Hide resolved
@Crispy-Salesforce
Copy link
Contributor

Please, can you include the WI? The Traceability Check fails. Thanks!

@dmerlob dmerlob dismissed stale reviews from Crispy-Salesforce, egrave, and themself via 937f8fa October 6, 2023 16:58
@dmerlob dmerlob changed the title added 4.5 example. Removed unsupported sample W-14250766-added 4.5 example. Removed unsupported sample Oct 6, 2023
dmerlob
dmerlob previously approved these changes Oct 6, 2023
View reviewed changes
modules/ROOT/pages/deploy-to-cloudhub.adoc Outdated Show resolved Hide resolved
@dmerlob dmerlob dismissed stale reviews from Crispy-Salesforce and themself via c93f9d8 October 6, 2023 17:06
@dmerlob dmerlob merged commit cf34682 into v4.4 Oct 6, 2023
5 checks passed
@dmerlob dmerlob deleted the W-14246809-4-5-Note branch October 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egrave egrave egrave left review comments

@Crispy-Salesforce Crispy-Salesforce Crispy-Salesforce approved these changes

@dmerlob dmerlob dmerlob left review comments

@dukesphere dukesphere Awaiting requested review from dukesphere

Assignees

@dmerlob dmerlob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nparente-mulesoft @Crispy-Salesforce @egrave @dmerlob