Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login with invalid account error #1688

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix login with invalid account error #1688

merged 1 commit into from
Apr 28, 2020

Conversation

jvff
Copy link
Contributor

@jvff jvff commented Apr 28, 2020

With the recent change to the REST API, the error that is used to determine if an account is invalid changed. This PR updates the mullvad-jni crate to properly handle the new error status code.

Git checklist:

  • Describe the change in CHANGELOG.md under the [Unreleased] header. Fixes a bug not present in any public release.
  • Check that commits follow the Mullvad coding guidelines

This change is Reviewable

@jvff jvff requested a review from pinkisemils April 28, 2020 13:08
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants