Fix crash when starting the service to handle a connect request #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
approved these changes
May 4, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
jvff
force-pushed
the
fix-start-service-crash
branch
from
6214b32
to
684902e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few crashes with an
IllegalStateExceptionwhen starting the service were reported on newer Android versions. Apparently, the cause is that a service can't be requested to be started without either being the result of a user interaction or having a promise that the service will be a foreground service. In theory, this rule is not applied for apps in a dynamic whitelist. This whitelist seems to be getting stricter with every release, since the crashes appear with the frequency increasing with the Android version.This PR fixes the issue by promising on those newer Android versions that the service will be a foreground service.
Git checklist:
CHANGELOG.mdunder the[Unreleased]header.This change is