Implement encrypted dns proxy in Electron GUI #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
8ba6fc1
to
0528bb6
Compare
raksooo
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Reviewed 9 of 21 files at r1, all commit messages.
Reviewable status: 9 of 21 files reviewed, all discussions resolved
MarkusPettersson98
changed the base branch from
main
to
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
9e301b3
to
41a3ffd
Compare
MarkusPettersson98
force-pushed
the
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
branch
from
af64c1c
to
dc83da6
Compare
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
41a3ffd
to
eca3ed4
Compare
MarkusPettersson98
force-pushed
the
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
branch
from
dc83da6
to
c2476d9
Compare
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
eca3ed4
to
39b60e1
Compare
raksooo
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Reviewed 14 of 14 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
-- commits line 16 at r3:
Apparently "Ellipsise" isn't a proper word 😆 How about "Handle API access method name overflow"? Could you change it?
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
39b60e1
to
55d24e4
Compare
There was a problem hiding this comment.
Reviewable status:
Previously, raksooo (Oskar Nyberg) wrote…
Apparently "Ellipsise" isn't a proper word 😆 How about "Handle API access method name overflow"? Could you change it?
What a shame 😆 I'll fix it 👍
MarkusPettersson98
force-pushed
the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
from
55d24e4
to
a9421ee
Compare
MarkusPettersson98
merged commit a9421ee
into
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
10 checks passed
MarkusPettersson98
deleted the
implement-encrypted-dns-proxy-in-gui-des-1273
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the GUI bits of #7010.
TODO
This change is