Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cool down period if TCP accept fails #44

Closed
wants to merge 2 commits into from
Closed

Conversation

mvd-ows
Copy link
Contributor

@mvd-ows mvd-ows commented Oct 3, 2023

As above.


This change is Reviewable

@mvd-ows mvd-ows requested a review from faern October 3, 2023 09:45
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @mvd-ows)


.github/workflows/ci.yml line 68 at r1 (raw file):

        include:
#          - os: ubuntu-latest
#            rust: nightly

This has to be reverted before merged.


src/tcp2udp.rs line 13 at r1 (raw file):

use std::time::Duration;
use tokio::net::{TcpListener, TcpSocket, TcpStream, UdpSocket};
use tokio::time::{sleep, Duration as tokio_Duration};

Tokio just re-exports std::time::Duration. So you don't need to import it here, the regular Duration is already in scope.

@mvd-ows mvd-ows force-pushed the use-accept-cooldown branch 2 times, most recently from 070bf20 to 677cc42 Compare October 3, 2023 17:27
@faern faern closed this Oct 25, 2023
@faern faern deleted the use-accept-cooldown branch October 25, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants