Set LIBDIR for remaining cmake-built libraries. #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#531 removed the
CMAKE_INSTALL_LIBDIR
configuration from libjpeg-turbo on the basis that it appeared to be redundant.#537 restored that flag, after it became clear that it isn't redundant - on any platform that uses the
lib64
convention,CMAKE_INSTALL_LIBDIR
is neededIn the discussion on #537, I speculated that it might be advisable to add the same flag to the other cmake libraries. It turns out I was right - if you set
CMAKE_INSTALL_LIB_NAME
and don't setCMAKE_INSTALL_LIBDIR
, you end up installing the library intolib64
, requiring a manual extra step to move the library to the location that matches the lib name; plus additional complications when the linked library references other libraries in lib64. This became apparent during testing on python-pillow/pillow#8497, because openjpeg libraries weren't lining up without additional post-build steps.This adds the
CMAKE_INSTALL_LIBDIR
configuration to openjpeg and blosc.