fix: list links of a block that _is a_ CID #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block is a CID, it is not listed by the block
.links()
method. This PR fixes that.For example, this is a block that is a CID:
P.S. I also removed the
npm run lint
command from thetest
script since theno-only-tests
rule was in the way of me being able to test my work. It is run in CI already. I can revert if anyone feels strongly in the opposite direction.As an aside:
It looks like there's not really a way to path through these kind of blocks, at least not with go/js ipfs.
For example, here's a tree with
node => CID node => node
:You cannot path to "Hello World!" from
bafyreidb7fynlo5246wst4tyl3wucfoskujuuq4523srgc73c6xlvnah2i
:Similarly in js-ipfs:
refs ipld/ipld#250