Optional blake3 #80
Merged
Optional blake3 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
reviewed
Aug 26, 2020
|
@thenextman Could you please try out this PR to see if it fixes your issue? |
|
@vmx I tested it, it works well on our side |
vmx
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Thank you @mriise for this PR and @thenextman for verifying that it works as expected.
|
Released as 0.11.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79
313 and 279 in hashes.rs seem a bit lazy to me, but it works fine and compiles down to the same size in the end. If you know of a better way of doing this please lmk, this just required the least amount of changes of actual logic.