-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow InListValidation to ignore missings #19
base: master
Are you sure you want to change the base?
Conversation
Waiting to see if this is solved by |
Hi, is there a chance these modifications are going to be merged? I am also interested in skipping NaNs in my application. |
As I said to the original author of this PR, please try |
You are right. I actually tried
Here the correct one:
Now it works as per the referred needs. |
Hi, I'm also having some issues with missing values when implementing InListValidation. Test example below:
I get the following error Since the "TestAllowEmpty" column has missing value, test_data["TestAllowEmpty"].dtypes = dtype('O'), hence neither a categorical dtype nor a numeric dtype. So the validation source code |
resolves #13