Smart Contract transfer and execute #340
Conversation
src/tokens.ts
Outdated
| } | ||
| } | ||
|
|
||
| export class TokenTransfer { |
There was a problem hiding this comment.
Here we'll have an issue 🙈
https://github.com/multiversx/mx-sdk-js-core/blob/main/src/tokenTransfer.ts
Let's brainstorm how to tackle this. Perhaps we can define a new sub-package, next, or perhaps we should use namespacing instead.
There was a problem hiding this comment.
I am using namespacing now. Let me know what you think about it.
| } | ||
| } | ||
|
|
||
| function decodeUnsignedNumber(arg: Buffer): number { |
There was a problem hiding this comment.
Can be moved near the other codec functions? Can also stay here for now, actually. We'll move it later, when / if needed.
| receiver = options.sender; | ||
| } | ||
| } | ||
| else if (numberOfTokens > 1) { |
There was a problem hiding this comment.
Else, without if (also for py). Also, formatting / (braces & newlines).
There was a problem hiding this comment.
As it is now, it doesn't properly work without else if. The code checks if someone provides a native token amount and custom token transfers but does not check if neither is provided. And it shouldn't check because you can simply call a contract function without doing any transfers. We check if the numberOfTokens == 1, but then if we use a simple else, and numberOfTokens = 0, the else branch get's executed and we don't want that since we don't have any transfers.
| this.token = token; | ||
| this.amount = amount; | ||
| } | ||
| export class NextTokenTransfer { |
Implemented the factory based on the specifications.