Add delegation controller #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+29
| sender: IAccount, | ||
| nonce: bigint, |
| async createTransactionForNewDelegationContract( | ||
| sender: IAccount, | ||
| nonce: bigint, | ||
| options: inputs.NewDelegationContractInput, |
There was a problem hiding this comment.
Good naming convention.
| @@ -20,7 +21,7 @@ interface IConfig { | |||
| additionalGasLimitForDelegationOperations: bigint; | |||
| } | |||
|
|
|||
| interface IValidatorPublicKey { | |||
| export interface IValidatorPublicKey { | |||
There was a problem hiding this comment.
Should not be exported, this is an internal interface. Can be handled as the other re-defined interfaces.
Comment on lines
341
to
354
| createTransactionForWithdrawing(_sender: IAddress, _options: inputs.ManageDelegationContractInput): Transaction { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| createTransactionForUndelegating(_sender: IAddress, _options: inputs.DelegateActionsInput): Transaction { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| createTransactionForRedelegatingRewards( | ||
| _sender: IAddress, | ||
| _options: inputs.ManageDelegationContractInput, | ||
| ): Transaction { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| createTransactionForClaimingRewards( | ||
| _sender: IAddress, |
There was a problem hiding this comment.
Spacing issue / newlines.
| import { TransactionWatcher } from "../transactionWatcher"; | ||
| import { DelegationTransactionsFactory } from "./delegationTransactionsFactory"; | ||
| import { DelegationTransactionsOutcomeParser } from "./delegationTransactionsOutcomeParser"; | ||
| import * as inputs from "./resources"; |
There was a problem hiding this comment.
inputs vs. resources - what if we also had outputs? Can also be simply, resources.
andreibancioiu
approved these changes
Nov 14, 2024
popenta
approved these changes
Nov 14, 2024
danielailie
deleted the
TOOL-352-add-delegation-controller-for-entrypoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.