Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension provider #59

Merged
merged 17 commits into from
Aug 20, 2021
Merged

Extension provider #59

merged 17 commits into from
Aug 20, 2021

Conversation

andreigiura
Copy link
Contributor

Implements extension provider

ccorcoveanu
ccorcoveanu requested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@ccorcoveanu ccorcoveanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks nice. Some small comments, but the main reason for the request changes review is:

  • Can you please add an entry to the Changelog in the Unreleased section regarding this PR? You already have examples there, it's pretty straight forward

src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
ccorcoveanu
ccorcoveanu reviewed Aug 19, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
src/dapp/extensionProvider.ts Outdated Show resolved Hide resolved
@bogdan-rosianu bogdan-rosianu self-requested a review August 20, 2021 07:11
@ccorcoveanu ccorcoveanu merged commit 6e40836 into development Aug 20, 2021
@ccorcoveanu ccorcoveanu deleted the extension-provider branch August 20, 2021 08:35
andreibancioiu added a commit that referenced this pull request Sep 25, 2024
@andreibancioiu
Merge pull request #59 from multiversx/fix-import-22
1a604a6 
Fix exports: "TransactionEventData"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccorcoveanu ccorcoveanu ccorcoveanu approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreigiura @ccorcoveanu @bogdan-rosianu