Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dev-dependencies (axios, in particular) #44

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Remove some dev-dependencies (axios, in particular) #44

merged 7 commits into from
Jan 18, 2024

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Jan 17, 2024 •
edited
Loading

For review: package lock file can be verified as follows:

git clone [email protected]:multiversx/mx-sdk-js-wallet.git && cd ./mx-sdk-js-wallet
npm uninstall axios
npm uninstall babelify
npm uninstall browserify
npm uninstall esmify

git diff origin/dev-dependencies-2024-01-17:package-lock.json package-lock.json

A npm audit fix will follow in the next PR.

@andreibancioiu andreibancioiu self-assigned this Jan 17, 2024
@andreibancioiu andreibancioiu changed the title Run npm audit fix for dev-dependencies Remove some dev-dependencies Jan 17, 2024
@andreibancioiu andreibancioiu changed the title Remove some dev-dependencies Remove some dev-dependencies (axios, in particular) Jan 17, 2024
@andreibancioiu andreibancioiu merged commit 4b585b0 into main Jan 18, 2024
1 check passed
@andreibancioiu andreibancioiu deleted the dev-dependencies-2024-01-17 branch January 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristure cristure cristure approved these changes

@danielailie danielailie danielailie approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @danielailie @cristure