Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set and update vcpkg baseline in manifest file, let CMake run vcpkg #22

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

davidebeatrici
Copy link
Member

Ports such as OpenSSL depend on MSYS2 packages on Windows, exhibiting a problem: when the packages are updated older versions are removed from the repository.

As a result, CI builds fail because all downloads break despite the numerous mirrors. This commit removes the vcpkgGitCommitId property, ensuring ports are always updated.

As for letting CMake run vcpkg: it's recommended by run-vcpkg's author.

As recommended by run-vcpkg's author (who is also run-cmake's).
@davidebeatrici davidebeatrici changed the title CI: Don't pin vcpkg to a specific commit and let CMake run it CI: Set and update vcpkg baseline in manifest file, let CMake run vcpkg Mar 3, 2024
@davidebeatrici davidebeatrici merged commit 00c1f15 into master Mar 3, 2024
8 checks passed
@davidebeatrici davidebeatrici deleted the ci-windows-failure-fix branch March 3, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant