-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce autoformatter #212
Open
Krzmbrzl
wants to merge
3
commits into
mumble-voip:master
Choose a base branch
from
Krzmbrzl:formatting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Continuous Integration | ||
|
|
||
| # This action works with pull requests and pushes | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| prettier: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Check code style | ||
| uses: creyD/[email protected] | ||
| with: | ||
| dry: true | ||
| working_directory: hugo/ | ||
| prettier_options: --check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ | |
| /public/ | ||
| /mumble-www.7z | ||
| /hugo/resources/_gen/ | ||
| *.lock | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| *.ice | ||
| *.html |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "printWidth": 120, | ||
| "proseWrap": "always" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,3 @@ title: "{{ replace .Name "-" " " | title }}" | |
| date: {{ .Date }} | ||
| draft: true | ||
| --- | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,118 +1,123 @@ | ||
| a { | ||
| color: black; | ||
| } | ||
|
|
||
| aside, em, i { | ||
| font-style: italic; | ||
| } | ||
|
|
||
| sup { | ||
| vertical-align: super; | ||
| } | ||
|
|
||
| sub { | ||
| vertical-align: sub; | ||
| } | ||
|
|
||
| h1 { | ||
| grid-template: "header"; | ||
| font-size: 200%; | ||
| align-self: center; | ||
| } | ||
|
|
||
| ul.menu { | ||
| list-style-type: none; | ||
| margin: 0; | ||
| padding: 0; | ||
|
|
||
| li { | ||
| display: inline-block; | ||
|
|
||
| a { | ||
| display: inline-block; | ||
| color: black; | ||
| text-align: center; | ||
| padding: 14px 16px; | ||
| text-decoration: none; | ||
|
|
||
| &:hover { | ||
| text-decoration: underline; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .markdown-body { | ||
| line-height: 1.7em; | ||
|
|
||
| ul { | ||
| list-style-type: disc; | ||
| padding-left: 0em; | ||
| } | ||
| b, strong { | ||
| font-weight: bold; | ||
| } | ||
| } | ||
|
|
||
| figure { | ||
| border: 0px solid #c0c0c0; | ||
| display: inline-block; | ||
| img { | ||
| display: block; | ||
| } | ||
| } | ||
| figcaption { | ||
| display: block; | ||
| background-color: #eeeeee; | ||
| /* font: italic smaller sans-serif; */ | ||
| font-style: italic; | ||
| padding: 3px 6px; | ||
| } | ||
| .figp { | ||
| display: block; | ||
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| @media (max-width: 1899px) { | ||
| aside.article-toc { display: none; } | ||
| } | ||
| .article-toc { | ||
| position: fixed; | ||
| right: 2em; | ||
| border: 1px solid #ccc; | ||
| border-radius: 0.4em; | ||
| padding: 4px 8px; | ||
| max-width: 280px; | ||
| } | ||
| .article-toc-title { | ||
| font-weight: bold; | ||
| } | ||
| .article-toc p { | ||
| margin-bottom: 0.4em; | ||
| } | ||
| .article-toc ul { | ||
| list-style-type: none; | ||
| padding-left: 0; | ||
| } | ||
|
|
||
| .label { | ||
| border: 1px solid #ccc; | ||
| background-color: #fcc; | ||
| /* color: red; */ | ||
| border-radius: 4px; | ||
| padding: 0px 2px; | ||
| } | ||
|
|
||
| .feed-icons { | ||
| text-align: right; | ||
| margin-top: 1em; | ||
| line-height: 32px; | ||
|
|
||
| a { | ||
| display: inline-block; | ||
| } | ||
| img { | ||
| width: 32px; | ||
| height: 32px; | ||
| } | ||
| } | ||
| a { | ||
| color: black; | ||
| } | ||
|
|
||
| aside, | ||
| em, | ||
| i { | ||
| font-style: italic; | ||
| } | ||
|
|
||
| sup { | ||
| vertical-align: super; | ||
| } | ||
|
|
||
| sub { | ||
| vertical-align: sub; | ||
| } | ||
|
|
||
| h1 { | ||
| grid-template: "header"; | ||
| font-size: 200%; | ||
| align-self: center; | ||
| } | ||
|
|
||
| ul.menu { | ||
| list-style-type: none; | ||
| margin: 0; | ||
| padding: 0; | ||
|
|
||
| li { | ||
| display: inline-block; | ||
|
|
||
| a { | ||
| display: inline-block; | ||
| color: black; | ||
| text-align: center; | ||
| padding: 14px 16px; | ||
| text-decoration: none; | ||
|
|
||
| &:hover { | ||
| text-decoration: underline; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .markdown-body { | ||
| line-height: 1.7em; | ||
|
|
||
| ul { | ||
| list-style-type: disc; | ||
| padding-left: 0em; | ||
| } | ||
| b, | ||
| strong { | ||
| font-weight: bold; | ||
| } | ||
| } | ||
|
|
||
| figure { | ||
| border: 0px solid #c0c0c0; | ||
| display: inline-block; | ||
| img { | ||
| display: block; | ||
| } | ||
| } | ||
| figcaption { | ||
| display: block; | ||
| background-color: #eeeeee; | ||
| /* font: italic smaller sans-serif; */ | ||
| font-style: italic; | ||
| padding: 3px 6px; | ||
| } | ||
| .figp { | ||
| display: block; | ||
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| @media (max-width: 1899px) { | ||
| aside.article-toc { | ||
| display: none; | ||
| } | ||
| } | ||
| .article-toc { | ||
| position: fixed; | ||
| right: 2em; | ||
| border: 1px solid #ccc; | ||
| border-radius: 0.4em; | ||
| padding: 4px 8px; | ||
| max-width: 280px; | ||
| } | ||
| .article-toc-title { | ||
| font-weight: bold; | ||
| } | ||
| .article-toc p { | ||
| margin-bottom: 0.4em; | ||
| } | ||
| .article-toc ul { | ||
| list-style-type: none; | ||
| padding-left: 0; | ||
| } | ||
|
|
||
| .label { | ||
| border: 1px solid #ccc; | ||
| background-color: #fcc; | ||
| /* color: red; */ | ||
| border-radius: 4px; | ||
| padding: 0px 2px; | ||
| } | ||
|
|
||
| .feed-icons { | ||
| text-align: right; | ||
| margin-top: 1em; | ||
| line-height: 32px; | ||
|
|
||
| a { | ||
| display: inline-block; | ||
| } | ||
| img { | ||
| width: 32px; | ||
| height: 32px; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I dislike max line widths quite a bit, especially narrow ones. It see it's at least 120, which could be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A maximum of 120 is consistent with how we format our C++ code.
I'd also be fine with let's say 150 but I really think line breaking increases readability as you're not dependent on your editor to do auto line wrapping.