FEAT(client, ui): Client-side JACK transport addon to multichannel recording feature #6043
Conversation
|
I didn't take a good look at the code yet, but it looks solid to me! Keep in mind that we could implement the same mechanism for PipeWire as well. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@davidebeatrici sounds good! It should be easy to implement a similar override for prepareOutputBuffers like I did for JACK. Please keep in mind that the PR is not quite complete, I still need to fix a couple of bugs and hook everything up to the recorder interface. Thanks for the feedback! |
|
There we go! Builds on all platforms and is pretty much polished; ready for review 😃 |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
950ae01
to
e1b7a9b
Compare
Since all the commits currently in your branch are really all implementing the same feature, you should squash them all down into a single commit. In the end, when your feature is reviewed, you should then add a translation commit by running the translation script in the Mumble repo. |
|
@Hartmnt can do. I'm busy the rest of the day so I'll have to look into this tomorrow. |
No hurry, I imagine there will be a few rounds of reviewing and updating going on here :3 |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
f846569
to
200d103
Compare
IsaMorphic
requested review from
Hartmnt
and removed request for
davidebeatrici
IsaMorphic
changed the title
|
I did re-request a review but I wanted to bump this just in case! |
|
This is still on my TODO list but I'm still busy with other stuff. Haven't forgotten about this though :) |
Krzmbrzl
added
client
recording
feature-request
|
Howdy! Just wanted to give a status update, I'm gonna try and finish this up this week or the week after. Excited to get this merged!! :D |
|
Thanks for the update 👍 |
|
@IsaMorphic just checking in here to check in on whether you still intend to finish this PR at some point. No need to hurry - a simple "yes" or "no" is enough for now. |
|
Yes! Eventually I'll get to it. Thanks! |
|
Hi @Krzmbrzl !! |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
c006a99
to
4ca8439
Compare
Whoopsie! Fixing this right away :) |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
a17c415
to
cc07ef4
Compare
|
OnO just realized I forgot about all my |
Alr that's done, I also did some other style fixes according to the guidelines I just realized exist 😅 |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
53a3ff5
to
7b2ebfa
Compare
|
@Krzmbrzl bump! No rush, but check this out when you can :) |
|
This has indeed survived a 1 hour stress test where I successfully recorded a podcast segment without issues or crashes. UI additions have also been tested for all possible edge cases. I'll implement the last of these changes tonight. Tysm <3 |
Perfect 👍 |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
3 times, most recently
from
913b6a3
to
639c1d9
Compare
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
639c1d9
to
c78c1b3
Compare
|
Hopefully that's everything lol! You have an eye for detail :3 |
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
7020cc1
to
6129ad9
Compare
|
Before this is merged your commits will have to be squashed together into the first FEAT commit (except for the TRANSLATION commit - that one will remain separate and after the FEAT commit) |
|
Sounds good. I'll be right on it. I'll be sure to fix that overflow bug too beforehand. |
… per-user audio capture/processing
IsaMorphic
force-pushed
the
feature/murmur-jack
branch
from
41a67d6
to
115fe26
Compare
|
Meow! :3 the deed is done. |
|
@Krzmbrzl not trying to be pushy, but any idea on when this might get merged? I'm so excited to have this contribution done and dusted! :D |
Solves #4112. I have chosen client-side support for the feature over server-side support due to the concerns over privacy and E2E encryption. See #3530 for relevant discussion.
Checks