-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#135 interactive programs #152
Conversation
69abf5d
to
b9c980c
Compare
}) | ||
.catch(() => { | ||
mumuki.kids.showResult({status: 'aborted'}) | ||
}); | ||
this.serverPromise = promise; | ||
|
||
editor.toggleInteractiveMode(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this only if editor.interactiveMode
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add an if here. It doesn't affect the current layout, as it is just toggling .play-mode that doesn't change anything without .mu-kids-interactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked only public API selectors are used?
I don't like the fact that
So maybe another solution could be compiling several files in one (like |
02fb627
to
300227c
Compare
300227c
to
7b62b60
Compare
Looks good, just please import hammer directly from the other assets, so that no extra import on laboratory is required. |
Resolves #135