Skip to content

Commit

Permalink
fix: use semicolon as a separator for glob inputs
Browse files Browse the repository at this point in the history
  • Loading branch information
murtuzaalisurti committed Sep 25, 2024
1 parent 5f5d63a commit d5e42cd
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
ai-model-api-key: ${{ secrets.MODEL_API_KEY }} # make sure to set this in your repository secrets - /settings/secrets/actions (Settings > Secrets and Variables > Actions > Secrets Tab)
platform: 'openai'
delete-existing-review-by-bot: true #default is true
filesToIgnore: '**/*.env, .husky/**' # uses glob patterns (micromatch - https://github.com/micromatch/micromatch)
filesToIgnore: '**/*.env; .husky/**; .cache/**' # uses glob patterns (micromatch - https://github.com/micromatch/micromatch)
rules: |- # Rules to consider for code review
-- It must follow industry standard best practices
-- It should be idiomatic
Expand Down Expand Up @@ -144,13 +144,13 @@ The rules to consider for code review. It is a multiline text field. Each rule s

### 7. `filesToIgnore` (Optional)

List of files to ignore. It is a comma(`,`) separated list of glob patterns. The default list of ignored files is:
List of files to ignore. It is a semicolon(`;`) separated list of glob patterns. The default list of ignored files is:

```text
**/node_modules/**,
**/package-lock.json,
**/yarn.lock,
.cache/**,
**/node_modules/**
**/package-lock.json
**/yarn.lock
.cache/**
**/*.{jpg,jpeg,png,svg,webp,avif,gif,ico,woff,woff2,ttf,otf}
```

Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ inputs:
rules:
description: "The rules to consider for code review"
filesToIgnore:
description: "List of files to ignore"
description: "List of files to ignore - a semicolon(;) separated list of glob patterns"
runs:
using: "node20"
main: "dist/index.js"
2 changes: 1 addition & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -58204,7 +58204,7 @@ async function run() {
const filesToIgnoreList = [
...new Set(
filesToIgnore
.split(",")
.split(";")
.map(file => file.trim())
.filter(file => file !== "")
.concat(FILES_IGNORED_BY_DEFAULT)
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ async function run() {
const filesToIgnoreList = [
...new Set(
filesToIgnore
.split(",")
.split(";")
.map(file => file.trim())
.filter(file => file !== "")
.concat(FILES_IGNORED_BY_DEFAULT)
Expand Down

0 comments on commit d5e42cd

Please sign in to comment.