Suggestions for Level 3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButenkoT
requested changes
Nov 4, 2016
| //we will get text '@NodeGirlsSydney' | ||
|
|
||
| ourTwitter.textContent; | ||
| // we will get text '@NodeGirlsSydney' |
There was a problem hiding this comment.
we will get text "Twitter: @NodeGirlsSydney @NodeGirlsMelb" as we had updates in html
| // kittens. Let's create a new image that sources our original logo file, and | ||
| // put it into header. | ||
| // | ||
| // P.S. Wou also can give styles to the new node that you create. |
|
Thank you a lot for polishing instructions! I very appreciate your help :) |
ajhyndman
force-pushed
the
brush-up-level-3
branch
from
c52b632
to
833d9bd
Compare
|
@ButenkoT I think I fixed your two suggestions. I'm glad you found it useful. :) |
ButenkoT
approved these changes
Nov 4, 2016
|
Those changes were right in time, as we run one event tomorrow. |
|
Oh, I didn't even realize that. I hope it goes great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.