Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key signature changes are not updated on next pages. #18490

Closed
orkuun opened this issue Jul 9, 2023 · 7 comments · Fixed by #18697
Closed

Key signature changes are not updated on next pages. #18490

orkuun opened this issue Jul 9, 2023 · 7 comments · Fixed by #18697
Assignees
Labels
engraving P1 Priority: High

Comments

@orkuun
Copy link

orkuun commented Jul 9, 2023

Issue type

Engraving bug

Bug description

For example, a score that starts in D Major will switch to C Major in the next measures/pages. If I select C Major, A Minor button from the palette and put it in the second measure of the second page, 2 sharps still appear on the next pages. This issue only happens on C Major, A Minor button.
As I understand it, this only happens with multi-instrument scores, and it happens after page two.
I made a video so it can be better understood from it.

Steps to reproduce

  1. New Score / Create From Template / Orchestral / Clasiccal Orchestra / Next
  2. Key Signature / D Major / Done
  3. Palettes / Key Signature / C Major, A Minor place in the second measure of the second page
  4. still looks sharp in front of the next page/pages

Screenshots/Screen recordings

https://youtu.be/7KWrsRJPBTc

MuseScore Version

MuseScore 4.1 RC

Regression

I don't know

Operating system

Windows 10, Linux Mint 21.1

Additional context

No response

@mercuree
Copy link
Contributor

mercuree commented Jul 9, 2023

I can confirm this. And also something is wrong with undo behaviour
OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.0-231890909, revision: github-musescore-musescore-5057202

undo_key_bug.mp4

@oktophonie
Copy link
Contributor

This appears to also be fixed by #18500.
In the 4.1 RC the problem exists as described, though it seems that it corrects itself as soon as a note is added after the C major key signature change.

@sammik
Copy link
Contributor

sammik commented Jul 10, 2023

@oktophonie I dont think, this "next page ks" issue is related #18500

I tried latest master (without #18500), and it works also there.

But strenge ks after undo seems to be fixed by #18500.
I say this, just to know, that adding only #18500 into 4.1 potencialy wouldnt fix major issue "next page".

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Jul 10, 2023

I can confirm this. And also something is wrong with undo behaviour OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.0-231890909, revision: github-musescore-musescore-5057202
undo_key_bug.mp4

That's covered in this huge bug #17718

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Jul 10, 2023

@oktophonie I dont think, this "next page ks" issue is related #18500

I tried latest master (without #18500), and it works also there.

I can confirm. The "next page ks" issue is fixed in latest nightly master (4.2) and still occurs in latest 4.1 nightly build

But strange ks after undo seems to be fixed by #18500.

Nope, unfortunately still happens in #18500 builds too

@oktophonie
Copy link
Contributor

Would love to find what's fixed this in master and cherry-pick for 4.1.1 then!

@RomanPudashkin
Copy link
Contributor

fixed in #18697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P1 Priority: High
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants