Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing and re-adding certain objects causes extra ones added (Clefs, Time signatures, Key signatures, Barlines, Repeats, Layout) #17718

Closed
LupusCaeruleus opened this issue May 24, 2023 · 1 comment · Fixed by #24205
Assignees
Labels
engraving P1 Priority: High regression MS3 Regression from MS3 (3.6.2) UX/interaction

Comments

@LupusCaeruleus
Copy link

LupusCaeruleus commented May 24, 2023

Issue type

Other type of issue

Bug description

Update: Also affects Clefs, Time sigs and Key sigs.

This bug seems to occur only on some objects of the panels Barlines, Repeats & Jumps and Layout.

When certain objects from the 3 panels are added then undo-ed, re-adding them will add one extra object to the next bar. See Steps to reproduce and Screen recording for more details.

Steps to reproduce

  1. Select a bar (or a range of bars) on the staff.
  2. Add any of the following objects below, by clicking them in their panels.
     Repeats & Jumps Panel: Segno symbols, Coda symbols, Texts, Repeat signs.
     Barlines Panel: Barlines.
     Layout Panel: Stave spacers, Frames, Insert one bar before selection.
  3. Press Ctrl+Z (or use other methods) to undo.
  4. Repeat step 2.
  5. One extra object is added to the next bar.

Expected behaviour: No extra objects should be added.

Screenshots/Screen recordings

2023-05-24.23-59-05.mp4
2023-05-25.00-27-22.mp4

MuseScore Version

4.0.2

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 10

Additional context

I noticed that after adding and undoing, the blue range selection box extends a little bit to the right and seems to enclose the barline on the right. Maybe this is the issue?

Normal selection:
image

After adding and undoing:
image

@muse-bot muse-bot added needs review The issue needs review to set priority, fix version or change status etc. regression MS3 Regression from MS3 (3.6.2) labels May 24, 2023
@LupusCaeruleus LupusCaeruleus changed the title Undoing and re-adding barlines, Repeats & Jumps, and Layout objects causes extra ones added Undoing and re-adding certain objects causes extra ones added May 24, 2023
@zacjansheski

This comment was marked as outdated.

@zacjansheski zacjansheski added P2 Priority: Medium and removed needs review The issue needs review to set priority, fix version or change status etc. labels May 26, 2023
@DmitryArefiev DmitryArefiev added P1 Priority: High and removed P2 Priority: Medium labels Jul 10, 2023
@DmitryArefiev DmitryArefiev changed the title Undoing and re-adding certain objects causes extra ones added Undoing and re-adding certain objects causes extra ones added (Clefs, Time signatures, Key signatures, Batlines, Repeats, Layout) Jul 10, 2023
@DmitryArefiev DmitryArefiev changed the title Undoing and re-adding certain objects causes extra ones added (Clefs, Time signatures, Key signatures, Batlines, Repeats, Layout) Undoing and re-adding certain objects causes extra ones added (Clefs, Time signatures, Key signatures, Barlines, Repeats, Layout) Jul 10, 2023
Nekotizimo added a commit to Nekotizimo/MuseScore that referenced this issue Aug 26, 2024
Nekotizimo added a commit to Nekotizimo/MuseScore that referenced this issue Aug 29, 2024
rpatters1 added a commit to rpatters1/MuseScore that referenced this issue Sep 25, 2024
* master:
  Work around Qt 6.2.5+ rich text hover bug
  Fix musescore#17718: actually check if previous measure is MMRest
  Restore clef/timesig/keysig at end of selection not start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P1 Priority: High regression MS3 Regression from MS3 (3.6.2) UX/interaction
Projects
10 participants