Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beam / tremolo layout refactor #16223

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Beam / tremolo layout refactor #16223

merged 4 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Extract beam layout algorithm into separate class 

    so that two-note tremolos can use it as well
    @asattely
    asattely committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d9c4cda View commit details
    Browse the repository at this point in the history

  2. Fix utests 

    The vast majority of these utest fixes are due to beam positions being able to occupy a floater space outside the staff if they slant away.

A few others add tremolo anchor point information which this PR added
    @asattely
    asattely committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e922458 View commit details
    Browse the repository at this point in the history

  3. review changes

    @asattely
    asattely committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9a93750 View commit details
    Browse the repository at this point in the history

  4. move BeamLayout to its own file 

    and rebase shenanigans for PR musescore#16719
    @asattely
    asattely committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2cc6de2 View commit details
    Browse the repository at this point in the history