Fix exporting PNG or SVG files with multiple pages #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
reviewed
Jul 4, 2023
| return excerpt->notation() == notation; | ||
| }); | ||
|
|
||
| if (it == potentialExcerpts.cend()) { | ||
| return notations.front()->elements()->pages().size(); | ||
| return notations.front()->elements()->pages().size() == 1; |
There was a problem hiding this comment.
I wonder why this didn't lead to a compiler warning, returning a size_t where a bool is wanted
RomanPudashkin
approved these changes
Jul 4, 2023
|
@cbjeukendrup It looks good now, but I found a case where it still happens: if to switch score to Continuous view (horizontal/vertical) bandicam.2023-07-04.14-58-24-232.mp4 |
|
Shouldn't the export always temporarily switch to page view? IIRC that is what Mu3 did Edit: ah, it does that already, just not when counting pages |
…tly viewed in Continuous view
cbjeukendrup
force-pushed
the
export_pngsvg_fix_filename_pagenumber
branch
from
53cbd92
to
c4add76
Compare
|
@DmitryArefiev That should be better now! |
|
@cbjeukendrup Yes, looks good now! Tested #18369 on Win10, Mac13, LinuxUbuntu 22.04 - FIXED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18369
🤦