Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing new options for ties, and a general overhaul of tie layout #19127

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Introducing new options for ties, and a general overhaul of tie layout #19127

merged 5 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. Tie layout overhaul 

    Move out piece of code to separate function

Introduce TiePlacement property and property type

correction

Introduce inspector section for tie placement

Created placeholder style widget for tie inside/outside

Update calculation of inside/outside according to new settings

Remove responsibility for setting pos out of adjustY

Rename SlurPos to SlurTiePos

Move computation of start and end system out of tie pos

correction

Temporarily deactivate adjustX and adjustY

Rationalize calculation of default start/end points

Force horizontal

correction

Re-implementation of adjustX

correction

Rationalize shoulder height formula and increase default curvature

Decrease thickness for short ties

Extract thickness calculation to dedicated method

initial reimplementation of adjustY

Implementing arc vs staffLine avoidance

correction

Better management of short ties

more

Don't do adjustments if autoplace is off

Correct dragging behaviour

cleanup

Fix glitches when when dragging ties

correction

improvements

Adjust for ledger lines

corrected values

Fix tie-to-tie collisions

Tweak curve

correction

correction

correction

margins above and below

correction

move some constants to style

correction

Final corrections
    @mike-spa
    mike-spa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b596466 View commit details
    Browse the repository at this point in the history

  2. Increase version number to 4.2 

    Update template files
    @mike-spa
    mike-spa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    41819b6 View commit details
    Browse the repository at this point in the history

  3. Introduce style compatibility for old scores

    @mike-spa
    mike-spa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f8f8835 View commit details
    Browse the repository at this point in the history

  4. added vtests 

    correction
    @mike-spa
    mike-spa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b2a40d3 View commit details
    Browse the repository at this point in the history

  5. Code review corrections 

    Code review corrections - 2

Code review corrections - 3

Code review corrections - 4

Code review corrections - 5
    @mike-spa
    mike-spa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3dfae78 View commit details
    Browse the repository at this point in the history