CI: bump all appimage deployment dependencies to latest for ARM #20363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove pkgconfig manual overrides for appimageupdatetool unnecessary on focal and newer distros
between the time that the original armhf/arm64 PR was made and now upstream has started building some dependencies for armhf/arm64 in their own CI and publishing releases. unfortunately we cannot use these releases since appimages (even the extraction command) do not run inside of the armhf/arm64 docker container AppImage/AppImageKit#1027 replace wget with curl (in make_appimage) due to armhf bug https://bugs.launchpad.net/ubuntu/+source/wget/+bug/2043636
|
Also please pick this to 4.2.0 branch as well test build is not complete yet, will be finished in a couple of hours https://github.com/theofficialgman/MuseScore/actions/runs/7133695213 |
cbjeukendrup
previously approved these changes
Dec 7, 2023
cbjeukendrup
dismissed
their stale review
Not completely ready for review yet
avoids needing gpgme which, in order to build, requires _FILE_OFFSET_BITS=64 which causes issues with linking to system libz.so.1 /usr/bin/ld: libzsync2_standalone.a(zsclient.cpp.o): undefined reference to symbol 'gzopen64@@ZLIB_1.2.3.3' /usr/bin/ld: /lib/arm-linux-gnueabihf/libz.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status AppImageCommunity/AppImageUpdate#230
theofficialgman
force-pushed
the
linuxdeploy-arm
branch
from
bbb8f0d
to
3f881d3
Compare
|
@rxhfcy you can test the build here for aarch64 https://github.com/theofficialgman/MuseScore/actions/runs/7133695213 I tried it on a Pi5 on PiOS Bookworm with Plasma Wayland DE. Unfortunately I get an error on launch |
|
huh I have the same issue on 4.1.1 on my x86_64 PC (also on Plasma Wayland but on Ubuntu Mantic) how has nobody reported this? |
@theofficialgman I clicked https://github.com/theofficialgman/MuseScore/actions/runs/7133695213, then https://github.com/theofficialgman/MuseScore/suites/18856497750/artifacts/1100562976, which downloaded Didn't launch: " |
|
(in the previous comment I was using 16K page size, "native" Fedora Asahi Remix 39 AArch64) @theofficialgman ...and just in case this is useful to you, I also tested using a 4K page size kernel (a similar Fedora 39 AArch64 VM in macOS UTM) |
igorkorsukov
approved these changes
Dec 8, 2023
|
@theofficialgman ...and here are even more details if you want to compare my console output between different MuseScore versions (please ignore if irrelevant) MuseScore latest nightly (4K ARM64 Fedora 39 VM) (click to reveal details)Normal Fedora distro version of MuseScore 4.1 (4K ARM64 Fedora 39 VM) (click to reveal details) |
|
@rxhfcy I don't need any reports about pagesize issues. the CI run I linked you did not have that fix from master yet No further testing needed. This PR functions but it does not really help as only pre-wayland 1.20 systems will properly launch (or x11) #18598 (comment) . This PR makes the issue the same on x86_64 as armhf/arm64. |
|
@theofficialgman OK. If you want someone to test something with 16K ARM Asahi Linux in the future, please feel free to @ me. Thanks for fixing these issues. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20356 (comment)
@cbjeukendrup
linuxdeploy-plugin-qt was too old on the arm setup script to use the EXTRA_PLATFORM_PLUGINS and so wayland qt plugins were not being added in arm builds.
the make_appimage.sh script was also updated to respect the passed architecture to the input but currently we still build the appimages for armhf/arm64 due to docker limitations with running appimages (specifically symptom number 2 here AppImage/AppImageKit#1027 (comment)). Not much time is saved by downloading vs building anyway for the newly available appimages (10 minutes less on the total 3hr build time).