Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable dragging/reordering of palettes #24211

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Aug 26, 2024

This PR allows disabling the ability of dragging palettes, to avoid unwanted reordering of them. It adds a checkable option to the palette context menu:
image

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros force-pushed the palette-drag branch 2 times, most recently from 4a8082d to 9f07d94 Compare August 27, 2024 13:29
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 28, 2024
RomanPudashkin added a commit that referenced this pull request Aug 28, 2024
mike-spa pushed a commit to mike-spa/MuseScore that referenced this pull request Aug 30, 2024
cbjeukendrup added a commit to cbjeukendrup/MuseScore that referenced this pull request Sep 2, 2024
Follow-up to musescore#24251, which was a follow-up to musescore#24211
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a technical point of view. @XiaoMigros Could you please rebase it?

@avvvvve
Copy link

avvvvve commented Oct 3, 2024

Looks good to me too (after confirming that it's turned on by default) BUT let's trim the copy down to just "Allow reordering palettes" please @XiaoMigros :)

@cbjeukendrup cbjeukendrup merged commit fc8445e into musescore:master Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants