Fix #24702: Voice too long corruption #24948
Merged
+53
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24702
Introduced with #23911
The idea here is to scan backwards from the input position to find the previous
ChordRest
, check if the duration overlaps with the input position, shorten the previousChordRest
by the length of the overlap, and fill any remaining gaps with tied notes (if necessary).This PR also addresses some janky input when switching voices in the middle of a tuplet (shown below) - for now we'll simply move the input cursor to the beginning of the tuplet. In future we may consider adding tuplets to the "new" voice in this case, but a few UX considerations will need to be resolved before we make this happen.
box-241001-1508-30.mp4