Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #24678: Remember which tab was last open within a session #24999

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix #24678: Remember which tab was last open within a session #24999

merged 1 commit into from
Oct 2, 2024
+25 −1

Conversation

pacebes
Copy link
Contributor

@pacebes pacebes commented Oct 1, 2024

Resolves: #24678

This change remembers the tab you where within the Preferences window when opening the window again within the same session.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pacebes pacebes force-pushed the 24678-rememberTabPreferencesWithinSession branch 2 times, most recently from a946d0d to 8560e29 Compare October 1, 2024 17:03
cbjeukendrup
cbjeukendrup reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments already!

src/appshell/iappshellconfiguration.h Outdated Show resolved Hide resolved
src/appshell/view/preferences/preferencesmodel.cpp Outdated Show resolved Hide resolved
@pacebes pacebes force-pushed the 24678-rememberTabPreferencesWithinSession branch 2 times, most recently from 27b18da to 5a69765 Compare October 1, 2024 17:18
@cbjeukendrup cbjeukendrup force-pushed the 24678-rememberTabPreferencesWithinSession branch from 27be495 to 1b9f9a5 Compare October 1, 2024 21:10
cbjeukendrup
cbjeukendrup approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the final fix myself; thanks a lot for your contribution!

@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#24678 FIXED

@cbjeukendrup cbjeukendrup merged commit dec01f9 into musescore:master Oct 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preferences: Remember which tab was last open within a session
3 participants
@pacebes @zacjansheski @cbjeukendrup