Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server header in middleware #204

Merged
merged 2 commits into from
Apr 3, 2019
Merged

add server header in middleware #204

merged 2 commits into from
Apr 3, 2019

Conversation

teeann
Copy link
Contributor

@teeann teeann commented Apr 1, 2019

Fix for #7

Steps to reproduce

  1. sudo clone --target http://example.com
  2. sudo snare --port 8080 --page-dir example.com
  3. curl --head http://localhost:8080/notfound. Response:
HTTP/1.1 200 OK
Content-Type: text/html; charset=utf-8
Content-Length: 1237
Date: Mon, 01 Apr 2019 16:49:00 GMT
Server: Python/3.6 aiohttp/3.4.4

Server header above is not changed to default nginx

@rnehra01
Copy link
Collaborator

rnehra01 commented Apr 2, 2019

The response code is 200 while it should be 404. Can you raise an issue for that and look into that before merging this?

@teeann
Copy link
Contributor Author

teeann commented Apr 2, 2019

Sure, I agree with you @rnehra01

@rnehra01 rnehra01 merged commit fe391ae into mushorg:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants